Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file-age not working anymore? #7308

Closed
melMass opened this issue Mar 20, 2024 · 6 comments · Fixed by #7313
Closed

file-age not working anymore? #7308

melMass opened this issue Mar 20, 2024 · 6 comments · Fixed by #7313
Labels
bug help wanted Please! ♥︎ Particularly useful features that everyone would love!

Comments

@melMass
Copy link

melMass commented Mar 20, 2024

Description

The file-age feature (#6340) seems to have broken very recently:
image

How to replicate the issue + URL

https://github.com/refined-github/refined-github

Extension version

24.3.20

Browser(s) used

Firefox

@melMass melMass added the bug label Mar 20, 2024
@fregante
Copy link
Member

Likely related to:

GitHub changed the variable color names so we should replace all of them at once as part of this issue.

PR welcome 🙏

@fregante fregante added help wanted Please! ♥︎ Particularly useful features that everyone would love! labels Mar 20, 2024
@melMass
Copy link
Author

melMass commented Mar 21, 2024

I'm going to try to setup a dev env for it, I couldn't quickly find how to test it locally but I might next week if no one did by then.
It seems like js-navigation-item doesn't exist anymore yet the react-directory-commit-age does have the proper style if I look from chrome tools but what is targeting title is now in a shadow-root:

image

@fregante
Copy link
Member

They probably changed the DOM too

@ilike2burnthing
Copy link
Contributor

Oddly it works when not signed in to GitHub (personal token or not, dark mode or light), and I can't see any difference in the HTML that would explain it.

@fregante
Copy link
Member

GitHub upgrades users gradually so some users (or maybe all registered users) get the new one, while the rest get it later.

Refined GitHub doesn't support logged out users so we can just replace the classes

@offensive-vk
Copy link

Same issue with Brave, Chrome in windows too.

fregante added a commit to kovsu/refined-github that referenced this issue Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted Please! ♥︎ Particularly useful features that everyone would love!
Development

Successfully merging a pull request may close this issue.

4 participants