Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick-review doesn't autofocus the field #7272

Open
fregante opened this issue Feb 23, 2024 · 3 comments
Open

quick-review doesn't autofocus the field #7272

fregante opened this issue Feb 23, 2024 · 3 comments
Labels
bug help wanted small Issues that new contributors can pick up

Comments

@fregante
Copy link
Member

Description

This selector doesn't match anything:

delegate('.js-reviews-container > details', 'toggle', focusReviewTextarea, {capture: true, signal});

First reported in #7256

How to replicate the issue + URL

  1. Open https://github.com/refined-github/sandbox/pull/12/files#review-changes-modal
  2. See the field not being focused

Extension version

24.2.8

Browser(s) used

Safari

@fregante fregante added bug help wanted small Issues that new contributors can pick up labels Feb 23, 2024
@sgrell
Copy link

sgrell commented Mar 25, 2024

hi, it sounds like only the css class needs to be fixed? I could prepare a PR to target the comment textarea or is the selector for some parent element?

@fregante
Copy link
Member Author

Yes I think only the selector needs to be updated. PR welcome

@sgrell
Copy link

sgrell commented Mar 25, 2024

I had a look at it, unfortunately I couldn't find an element to make the delegate call with toggle work, so that the check for open works. If I disable the if in focusReviewTextarea and only use .js-reviews-container as a selector, the textarea is highlighted but of course now we try to focus the textarea too often.

So I think, I won't be able to help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted small Issues that new contributors can pick up
Development

No branches or pull requests

2 participants