previous-next-commit-buttons not adding buttons at the bottom of the commits page

[adrianschmidt]

Description

I've had this problem for quite a while (several months at least), and the fact that there doesn't seem to be any issues about this makes me wonder if it's a problem only on my machine. Anyway, I thought I'd open this issue to find out.

The problem is that the previous-next-commit-buttons feature of Refined GitHub doesn't work, in that it does not create the extra buttons at the bottom of the page when reviewing the diff for a single commit on a pull request. In fact, the feature doesn't seem to run at all, as it's not listed in the Console tab of the browser dev tools.

My screen recording got too big to attach directly to the description, so I've uploaded it to Google Drive: https://drive.google.com/file/d/1Z_h31c5BCnP-g1o49YM7GgJ8ARkSsf4u/view?usp=sharing

(The example is a merged pull request, but everything appears exactly the same on an open PR, as far as I can see. If you prefer seeing it replicated on an open PR, please just tell me, and I'll make another screen recording! 🙂)

How to replicate the issue + URL

1. Enable the previous-next-commit-buttons feature.
2. Go to a pull request with multiple commits.
3. Click the Commits tab, and then on one of the commits.
4. Scroll to the bottom of the page.

Expected: There should be buttons for navigating to the previous and next commits.

Actual: No such buttons appear.

URL: Lundalogik/lime-elements@9726b8f (#2739) (This is a link to a merged PR. But there are usually plenty of open PRs in the same repo, so feel free to navigate around!)

Extension version

24.1.10

Browser(s) used

Chrome Dev — Version 123.0.6262.5 (Official Build) dev (x86_64)
Chrome – Version 121.0.6167.85 (Official Build) (x86_64)

Refined GitHub options

I've redacted my access token in the options below, but here is a screenshot of the privilege checks:

{
	"__webextOptionsSync": "Refined GitHub",
	"actionUrl": "",
	"customCSS": "",
	"personalToken": "[redacted]",
	"logging": true,
	"logHTTP": true,
	"feature:action-pr-link": true,
	"feature:action-used-by-link": true,
	"feature:actionable-pr-view-file": true,
	"feature:align-issue-labels": true,
	"feature:archive-forks-link": true,
	"feature:avoid-accidental-submissions": true,
	"feature:batch-mark-files-as-viewed": true,
	"feature:bugs-tab": true,
	"feature:ci-link": true,
	"feature:clean-conversation-filters": true,
	"feature:clean-conversation-headers": true,
	"feature:clean-conversation-sidebar": false,
	"feature:clean-pinned-issues": true,
	"feature:clean-readme-url": true,
	"feature:clean-repo-filelist-actions": true,
	"feature:clean-repo-sidebar": true,
	"feature:clean-repo-tabs": true,
	"feature:clean-rich-text-editor": true,
	"feature:clear-pr-merge-commit-message": true,
	"feature:click-outside-modal": true,
	"feature:close-as-unplanned": true,
	"feature:close-out-of-view-modals": true,
	"feature:closing-remarks": true,
	"feature:collapsible-content-button": true,
	"feature:command-palette-navigation-shortcuts": true,
	"feature:comment-fields-keyboard-shortcuts": true,
	"feature:comment-on-draft-pr-indicator": true,
	"feature:comments-time-machine-links": true,
	"feature:conflict-marker": true,
	"feature:conversation-activity-filter": true,
	"feature:conversation-links-on-repo-lists": true,
	"feature:convert-pr-to-draft-improvements": true,
	"feature:convert-release-to-draft": true,
	"feature:copy-on-y": true,
	"feature:create-release-shortcut": true,
	"feature:cross-deleted-pr-branches": true,
	"feature:deep-reblame": true,
	"feature:default-branch-button": true,
	"feature:dim-bots": true,
	"feature:download-folder-button": true,
	"feature:easy-toggle-commit-messages": true,
	"feature:easy-toggle-files": true,
	"feature:embed-gist-inline": true,
	"feature:embed-gist-via-iframe": true,
	"feature:emphasize-draft-pr-label": true,
	"feature:esc-to-cancel": true,
	"feature:esc-to-deselect-line": true,
	"feature:expand-all-hidden-comments": true,
	"feature:extend-conversation-status-filters": true,
	"feature:extend-diff-expander": true,
	"feature:file-age-color": true,
	"feature:fit-textareas": true,
	"feature:fix-no-pr-search": true,
	"feature:github-actions-indicators": true,
	"feature:global-conversation-list-filters": true,
	"feature:hidden-review-comments-indicator": true,
	"feature:hide-diff-signs": true,
	"feature:hide-inactive-deployments": true,
	"feature:hide-issue-list-autocomplete": true,
	"feature:hide-low-quality-comments": true,
	"feature:hide-navigation-hover-highlight": true,
	"feature:hide-newsfeed-noise": true,
	"feature:hide-user-forks": true,
	"feature:highest-rated-comment": true,
	"feature:highlight-collaborators-and-own-conversations": true,
	"feature:highlight-non-default-base-branch": true,
	"feature:html-preview-link": true,
	"feature:improve-shortcut-help": true,
	"feature:infinite-scroll": true,
	"feature:jump-to-change-requested-comment": true,
	"feature:jump-to-conversation-close-event": true,
	"feature:keyboard-navigation": true,
	"feature:last-notification-page-button": true,
	"feature:link-to-changelog-file": true,
	"feature:link-to-compare-diff": true,
	"feature:link-to-github-io": true,
	"feature:linkify-branch-references": true,
	"feature:linkify-code": true,
	"feature:linkify-commit-sha": true,
	"feature:linkify-labels-on-dashboard": true,
	"feature:linkify-notification-repository-header": true,
	"feature:linkify-symbolic-links": true,
	"feature:linkify-user-edit-history-popup": true,
	"feature:linkify-user-labels": true,
	"feature:linkify-user-location": true,
	"feature:list-prs-for-branch": true,
	"feature:list-prs-for-file": true,
	"feature:locked-issue": true,
	"feature:mark-merge-commits-in-list": true,
	"feature:mark-private-orgs": true,
	"feature:mobile-tabs": true,
	"feature:more-conversation-filters": true,
	"feature:more-dropdown-links": true,
	"feature:more-file-links": true,
	"feature:netiquette": true,
	"feature:new-or-deleted-file": true,
	"feature:new-repo-disable-projects-and-wikis": true,
	"feature:no-duplicate-list-update-time": true,
	"feature:no-unnecessary-split-diff-view": true,
	"feature:one-click-diff-options": true,
	"feature:one-click-pr-or-gist": true,
	"feature:one-click-review-submission": true,
	"feature:one-key-formatting": true,
	"feature:open-all-conversations": true,
	"feature:open-all-notifications": true,
	"feature:open-issue-to-latest-comment": true,
	"feature:pagination-hotkey": true,
	"feature:parse-backticks": true,
	"feature:patch-diff-links": true,
	"feature:pinned-issues-update-time": true,
	"feature:pr-base-commit": true,
	"feature:pr-branch-auto-delete": true,
	"feature:pr-commit-lines-changed": true,
	"feature:pr-filters": true,
	"feature:pr-jump-to-first-non-viewed-file": true,
	"feature:pr-notification-link": true,
	"feature:prevent-comment-loss": true,
	"feature:prevent-duplicate-pr-submission": true,
	"feature:prevent-link-loss": true,
	"feature:prevent-pr-merge-panel-opening": true,
	"feature:preview-hidden-comments": true,
	"feature:previous-next-commit-buttons": true,
	"feature:previous-version": true,
	"feature:profile-gists-link": true,
	"feature:profile-hotkey": true,
	"feature:pull-request-hotkeys": true,
	"feature:quick-comment-edit": true,
	"feature:quick-comment-hiding": true,
	"feature:quick-file-edit": true,
	"feature:quick-label-removal": true,
	"feature:quick-mention": true,
	"feature:quick-new-issue": true,
	"feature:quick-repo-deletion": false,
	"feature:quick-review": true,
	"feature:quick-review-comment-deletion": true,
	"feature:reactions-avatars": true,
	"feature:release-download-count": true,
	"feature:releases-dropdown": true,
	"feature:releases-tab": true,
	"feature:reload-failed-proxied-images": true,
	"feature:repo-age": true,
	"feature:repo-avatars": true,
	"feature:repo-header-info": true,
	"feature:repo-wide-file-finder": true,
	"feature:resolve-conflicts": true,
	"feature:restore-file": true,
	"feature:rgh-dim-commits": true,
	"feature:rgh-feature-descriptions": true,
	"feature:rgh-improve-new-issue-form": true,
	"feature:rgh-linkify-features": true,
	"feature:rgh-linkify-yolo-issues": true,
	"feature:rgh-netiquette": true,
	"feature:rgh-pr-template": true,
	"feature:rgh-welcome-issue": true,
	"feature:same-branch-author-commits": true,
	"feature:scrollable-areas": true,
	"feature:select-all-notifications-shortcut": true,
	"feature:select-notifications": true,
	"feature:selection-in-new-tab": true,
	"feature:shorten-links": true,
	"feature:show-associated-branch-prs-on-fork": true,
	"feature:show-names": true,
	"feature:show-open-prs-of-forks": true,
	"feature:show-user-top-repositories": true,
	"feature:show-whitespace": true,
	"feature:small-user-avatars": true,
	"feature:sort-conversations-by-update-time": true,
	"feature:status-subscription": true,
	"feature:sticky-sidebar": true,
	"feature:stop-redirecting-in-notification-bar": true,
	"feature:submission-via-ctrl-enter-everywhere": true,
	"feature:suggest-commit-title-limit": true,
	"feature:swap-branches-on-compare": true,
	"feature:sync-pr-commit-title": true,
	"feature:tab-to-indent": true,
	"feature:table-input": true,
	"feature:tag-changes-link": true,
	"feature:tags-on-commits-list": true,
	"feature:toggle-everything-with-alt": true,
	"feature:toggle-files-button": true,
	"feature:unfinished-comments": true,
	"feature:unreleased-commits": true,
	"feature:unwrap-unnecessary-dropdowns": true,
	"feature:update-pr-from-base-branch": true,
	"feature:use-first-commit-message-for-new-prs": false,
	"feature:useful-not-found-page": true,
	"feature:user-local-time": true,
	"feature:user-profile-follower-badge": true,
	"feature:vertical-front-matter": true,
	"feature:view-last-pr-deployment": true,
	"feature:visit-tag": true,
	"feature:wait-for-checks": true,
	"feature:warn-pr-from-master": true,
	"feature:warning-for-disallow-edits": true
}