Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync-pr-commit-title - "Cancel" requires two clicks #7096

Open
fregante opened this issue Nov 23, 2023 · 1 comment
Open

sync-pr-commit-title - "Cancel" requires two clicks #7096

fregante opened this issue Nov 23, 2023 · 1 comment
Labels
bug help wanted small Issues that new contributors can pick up

Comments

@fregante
Copy link
Member

Description

I don’t think this is caused by us, but probably there's an event listener that cancels propagation so our delegate() never receives the event:

Screen.Recording.mov

It seems to be related with the focus of the field, because if I blur it first, it works with one click. This is also true when blurring via tab

Screen.Recording.1.mov

How to replicate the issue + URL

refined-github/sandbox#12

Extension version

23.11.3, 23.11.15

Browser(s) used

Chrome, Safari

@fregante fregante added bug help wanted small Issues that new contributors can pick up labels Nov 23, 2023
@fregante
Copy link
Member Author

I tried capture: true here but that was not enough.

// On "Cancel", disable the feature
delegate('.rgh-sync-pr-commit-title', 'click', disableSubmission, {signal});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted small Issues that new contributors can pick up
Development

No branches or pull requests

1 participant