Some features show information from the wrong/previous repository visited

[134130]

Description

• repo-header-info show invalid repository's stargazer-count.
• 

How to replicate the issue + URL

1. Clear cache of refined-github
2. Go to https://github.com/refined-github/refined-github
3. Go to it's organization with Left top's breadcrumb
   
4. Go to other repository
5. Check your repo-header-info stargazer-count

Extension version

23.10.5

Browser(s) used

Chrome

[134130]

The reason is CachedFunction's cacheKey is initialized with refined-github/refined-github, and visiting other repository with out script reloading (soft-rendering), CachedFunction still has cacheKey to refined-github/refined-github

https://github.com/refined-github/refined-github/blob/main/source/features/repo-header-info.tsx#L20-L28

There can be same cache issues which initializes CachedFunction like this case.

[fregante]

That cacheKey is dynamic, it depends on location.href

Maybe the issue is that it's fired at the wrong time due to:

• Features are de-inited too late on ajax navigation #6437

[134130]

That cacheKey is dynamic, it depends on location.href

Maybe the issue is that it's fired at the wrong time due to:

• Features are de-inited too late on ajax navigation #6437

Yes. I've checked cacheKey is correctlly updated on feature init callback.
But, the cacheKey is passed to CachedFunction's constuctor as value, cannot apply location.href dynamically, when soft-rendering cases.

Fix : My bad. CacheKey is not related. Maybe you are right. We need to figure out why gql is querying with previous repository. I'll check it later.

[fregante]

I have a repro for another feature, default-branch-button:

1. Clear cache
2. Open this in a new tab https://github.com/sindresorhus/p-retry/releases/tag/v6.1.0
3. Click "separate package"
4. Open a file or folder

Screen.Recording.mov

[fregante]

Oof, it doesn't simply mess up the current view, but it also messes up the cache. I thought this was just a few issue, but for some reason it takes the previous value and stores it on the current URL.

My guess is that getRepo is called at different times, or that webext-storage-cache is memoizing the function call incorrectly.

[134130]

Not sure, but as you said, It appeares frequently and commonly on other features also.

[fregante]

The issue is:

• Don't use globals in parametrized functions #6637
• Memoization
• specifically api.v4

refined-github/source/github-helpers/api.ts

Lines 168 to 177 in 2072f43

	export const v4uncached = async (
	query: string,
	options: GHGraphQLApiOptions = v4defaults,
	): Promise<AnyObject> => {
	const personalToken = await expectToken();
	// TODO: Remove automatic usage of globals via `getRepo()`
	// https://github.com/refined-github/refined-github/issues/5821
	const currentRepoIfAny = getRepo(); // Don't destructure, it's `undefined` outside repos
	query = query.replace('repository() {', () => 'repository(owner: $owner, name: $name) {');

I thought I had fixed this in

refined-github/source/github-helpers/api.ts

Lines 234 to 246 in 2072f43

	export const v4 = mem(v4uncached, {
	cacheKey([query, options]) {
	// `repository()` uses global state and must be handled explicitly
	// https://github.com/refined-github/refined-github/issues/5821
	// https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1864
	const key = [query, options];
	if (query.includes('repository() {')) {
	key.push(getRepo()?.nameWithOwner);
	}
	return JSON.stringify(key);
	},
	});