-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review @primer/octicons-react
usage, update/replace dependency
#6878
Labels
Comments
fregante
added
help wanted
meta
Related to Refined GitHub itself
under discussion
labels
Sep 4, 2023
Extracted from #6000 (comment) |
This issue is made super visible by |
Yeah let's restore SVGR soon so we'll skip all the React drama. I think the npm package still includes the SVG: https://github.com/fregante/github-issue-link-status/blob/main/source/icons.js (That file is handled by parcel so the syntax isn't the same) |
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our
@primer/octicons-react
package cannot be updated:There were a couple of attempts at fixing this:
dom-chef
withjsx-dom
#4044Probably
jsx-dom
is the best transition we can do right now, but also it's probably not working with v19.So I think the easiest way forward would be to:
This should be reasonably easy to implement and likely the most stable and lightweight solution (octicons-react has more code than we need, at this point)
The text was updated successfully, but these errors were encountered: