Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertical-front-matter: only works on first load after cache clear #6865

Closed
simon-abbott opened this issue Sep 1, 2023 · 2 comments · Fixed by #7069
Closed

vertical-front-matter: only works on first load after cache clear #6865

simon-abbott opened this issue Sep 1, 2023 · 2 comments · Fixed by #7069
Labels
bug help wanted small Issues that new contributors can pick up

Comments

@simon-abbott
Copy link

Description

vertical-front-matter only works on the first load after the extension cache has been cleared. On all further loads it simply does nothing with no console errors.

Screen.Recording.2023-09-01.at.4.35.40.PM.mov

How to replicate the issue + URL

https://github.com/github/docs/blob/main/content/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github.md

Extension version

23.8.24

Browser(s) used

Firefox

@fregante
Copy link
Member

fregante commented Sep 1, 2023

Thank you for the report! This is due to:

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2023
@fregante
Copy link
Member

fregante commented Sep 1, 2023

On second look, I don't know what's causing it. Cache shouldn't be an issue here, it's likely a race condition because there's no "await dom ready" in the feature.

PR welcome to rewrite it using our selector observer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted small Issues that new contributors can pick up
2 participants