Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore-file requires two steps on renamed files #6679

Closed
fregante opened this issue May 21, 2023 · 0 comments · Fixed by #6715
Closed

restore-file requires two steps on renamed files #6679

fregante opened this issue May 21, 2023 · 0 comments · Fixed by #6715
Labels
bug help wanted

Comments

@fregante
Copy link
Member

Description

Current situation:

  1. Fetches info for the current filename in the base commit
  2. Current filename doesn't exist on base branch
  3. Deletes new filename, but does not restore the previous filename
  4. UI is updated to show the previous file still being deleted

Expected:

  1. We can extract the old filename from the PR UI
  2. We have to both delete the new file and re-create the old one.

I think we used to have this code… maybe we removed it because it was too complex

How to replicate the issue + URL

  1. testing restore-file sandbox#16

Extension version

23.5.10

Browser(s) used

Chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle renamed files in restore-file refined-github/refined-github
1 participant
@fregante