Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear-pr-merge-commit-message occasionally fails #6611

Open
fregante opened this issue May 4, 2023 · 2 comments
Open

clear-pr-merge-commit-message occasionally fails #6611

fregante opened this issue May 4, 2023 · 2 comments

Comments

@fregante
Copy link
Member

fregante commented May 4, 2023

Description

This commit was sent (notice non-empty commit body)

b3e7358

How to replicate the issue + URL

  1. Open PR with a bunch of files sandbox#55
  2. Click "Merge" to open the box
  3. Notice that the box has been cleared
  4. Submit a new comment
  5. Notice box is closed when the comment is submitted
  6. Reopen box
  7. ❌ The commit message has returned and is empty

Extension version

23.4.15

Browser(s) used

Safari

@fregante fregante added the bug label May 4, 2023
@fregante fregante changed the title clear-pr-commit-message occasionally fails clear-pr-merge-commit-message occasionally fails May 4, 2023
@raiyni
Copy link

raiyni commented Dec 23, 2023

Not sure if this is the correct issue but this has been happening for a few months now where the extended description box for Squash and merge is filled with all of the commit message garbage.

image

@fregante
Copy link
Member Author

My guess is that GitHub fills up the field a second time, but Refined GitHub does not catch that because it's the same field.

Maybe GitHub fires some event we can listen to, or we have to go back to the "open merge box" event via delegate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants