New empty has-rgh element added on turbo frame navigations

[JoshuaKGoldberg]

Description

I'm seeing empty <has-rgh></has-rgh> elements getting added inside <main id="js-repo-pjax-container"> on a GitHub issues/PRs page every time I navigate between the two. They're added once per navigation and never removed. Is this some kind of element leak / bug with GH's SPA navigation?

Note that I don't have a Personal Access Token in my options. But I would consider this a bug regardless of PAT status. 😄

How to replicate the issue + URL

1. Visit a repo's Issues page
2. Click the Pull requests tab
3. Click the Issues tab
4. Repeat 2 & 3 a few times

Extension version

23.4.10

Browser(s) used

Chrome on macOS

[fregante]

Thanks for the report, we indeed never remove it:

refined-github/source/feature-manager.tsx

Lines 309 to 323 in 9c438be

	/*
	When navigating back and forth in history, GitHub will preserve the DOM changes;
	This means that the old features will still be on the page and don't need to re-run.
	This marks each as "processed"
	*/
	void add('rgh-deduplicator' as FeatureID, {
	awaitDomReady: true,
	async init() {
	// `await` kicks it to the next tick, after the other features have checked for 'has-rgh', so they can run once.
	await Promise.resolve();
	select(_`#js-repo-pjax-container, #js-pjax-container`)?.append(<has-rgh/>);
	select(_`turbo-frame`)?.append(<has-rgh-inner/>); // #4567
	},
	});

Due to recent AJAX issues, we're being extra cautious with avoiding duplicates of actual elements on the page, so you get duplicate hidden elements in your DOM. I'll keep this open to track the general issue but it's not something we will fix before the big ones are figured out:

• Features are de-inited too late on ajax navigation #6437
• React-based views don't correctly update features #6554