Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

one-click-diff-options visually broken #6364

Closed
fregante opened this issue Feb 20, 2023 · 5 comments
Closed

one-click-diff-options visually broken #6364

fregante opened this issue Feb 20, 2023 · 5 comments
Labels
bug help wanted Please! ♥︎ Particularly useful features that everyone would love!

Comments

@fregante
Copy link
Member

fregante commented Feb 20, 2023 •
edited

Description

Super fresh issue. Could be temporary, but I'm hotfixing the feature immediately.

Screenshot 3

How to replicate the issue + URL

https://github.com/refined-github/sandbox/pull/7/files

Extension version

23.2.1

Browser(s) used

Safari
@fregante fregante added bug help wanted disabled via hotfix A label to remind us to remove the feature from yolo labels Feb 20, 2023
fregante added a commit to refined-github/yolo that referenced this issue Feb 20, 2023
@fregante
Disable one-click-diff-options
640dbb8 
refined-github/refined-github#6364
@fregante
Copy link
Member Author

I can't reproduce this in Chrome 🤔 even when building 23.2.1.

This is the DOM in Safari:

Screenshot

I'll tentatively re-enable the feature for 23.2.20 and wait for further reports

@fregante fregante added the Please! ♥︎ Particularly useful features that everyone would love! label Mar 2, 2023
@fregante fregante removed the disabled via hotfix A label to remind us to remove the feature from yolo label Mar 9, 2023
@fregante
Copy link
Member Author

fregante commented Mar 9, 2023 •
edited

This seems to be a race condition, it only appears sometimes. I assume it's due to the selector observer running early (similarly to elementReady('', {waitForChildren: false}))

Similar:

@fregante
Copy link
Member Author

Potentially related to:

@fregante
Copy link
Member Author

fregante commented Jul 24, 2023 •
edited

I haven't seen this in a while. There's a chance it was related to and fixed by:

Closing for now. Will reopen if I see it

@github-actions
Copy link

To maintainers: Disable the hotfix by adding 23.7.24 to https://github.com/refined-github/yolo/edit/main/broken-features.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted Please! ♥︎ Particularly useful features that everyone would love!
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fregante