Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shorten-links incorrectly shorten links within tables on GH Enterprise #6106

Closed
NickBolles opened this issue Oct 24, 2022 · 3 comments
Closed
Labels
bug enterprise Related to GitHub Enterprise only help wanted

Comments

@NickBolles
Copy link

NickBolles commented Oct 24, 2022

Description

This is essentially the same as #5630 just that the fix still doesn't work for our GH enterprise 3.4.9.

Example Markdown:

Test Method Command/Build info
TEST RUNNER
run.rb --host https://foo.bar.com/artifactory/ \
--version 589465
run.rb --host https://foo.bar.com/artifactory/ \
--version 589465

screenshot of that example on github enterprise:

image

HTML from example:

<td class="d-block comment-body markdown-body js-comment-body">
  <table role="table">
    <thead>
      <tr>
        <th>Test Method</th>
        <th>Command/Build info</th>
      </tr>
    </thead>
    <tbody>
      <tr>
        <td>TEST RUNNER</td>
        <td>
          <pre>run.rb --host <a href="https://foo.bar.com/artifactory/" rel="nofollow" class="rgh-seen-2855565660">foo.bar.com/artifactory</a> \<br>--version 589465</pre>
        </td>
      </tr>
    </tbody>
  </table>
  <pre>run.rb --host https://foo.bar.com/artifactory/ \<br>--version 589465</pre>
</td>

How to replicate the issue + URL

See above for repro, I think that should be enough info but please let me know if it doesn't

Extension version

22.10.12

Browser(s) used

Edge 106.0.1370.52

@NickBolles NickBolles added the bug label Oct 24, 2022
@NickBolles
Copy link
Author

NickBolles commented Oct 24, 2022

Looks like #6006 changed this code some, but TBH, I'm not sure if it ever worked on enterprise

@fregante
Copy link
Member

Thanks for the detailed issue 💙

We had the same issue before and it was fixed, in fact I also made tables part of our testbed for the feature: refined-github/sandbox#14

I suppose GHE has a slightly different DOM that broke it. 😕

@fregante fregante added help wanted enterprise Related to GitHub Enterprise only labels Oct 24, 2022
@fregante
Copy link
Member

I'm going to close this assuming that it has been fixed since. GHE is updated later

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enterprise Related to GitHub Enterprise only help wanted
Development

No branches or pull requests

2 participants