From 2072f43975d170a312befeba65ae487b1bb0f2c9 Mon Sep 17 00:00:00 2001 From: Federico Brigante Date: Wed, 15 Nov 2023 14:05:43 +0800 Subject: [PATCH] `minimize-upload-bar` - Drop feature (#7057) --- readme.md | 1 - source/features/minimize-upload-bar.css | 26 ------------------------- source/features/minimize-upload-bar.tsx | 6 ------ source/refined-github.ts | 1 - 4 files changed, 34 deletions(-) delete mode 100644 source/features/minimize-upload-bar.css delete mode 100644 source/features/minimize-upload-bar.tsx diff --git a/readme.md b/readme.md index 00962e3f36b..eca72ad5d88 100644 --- a/readme.md +++ b/readme.md @@ -197,7 +197,6 @@ Thanks for contributing! πŸ¦‹πŸ™Œ - [](# "quick-comment-edit") [Lets you edit any comment with one click instead of having to open a dropdown.](https://user-images.githubusercontent.com/46634000/162252055-54750c89-0ddc-487a-b4ad-cec6009d9870.png) - [](# "comment-fields-keyboard-shortcuts") [Adds a shortcut to edit your last comment: ↑.](https://github.com/refined-github/refined-github/pull/961) (Only works in the following comment field, if it’s empty.) - [](# "one-key-formatting") [Wraps selected text when pressing one of Markdown symbols instead of replacing it:](https://github-production-user-asset-6210df.s3.amazonaws.com/83146190/261155564-e7aabd0e-b14b-4fe6-b379-62e7419c43f8.gif) `[` `` ` `` `'` `"` `*` `~` `_` -- [](# "minimize-upload-bar") [Reduces the upload bar to a small button.](https://user-images.githubusercontent.com/17612510/99140148-205dd380-2693-11eb-9a61-9c228f8f9e36.png) - [](# "clean-rich-text-editor") [Hides unnecessary comment field tooltips and toolbar items](https://user-images.githubusercontent.com/46634000/158201651-7364aba7-f9d0-4a51-89c4-2ced0cc34e48.png) (each one has a keyboard shortcut.) - [](# "quick-mention") [Adds a button to `@mention` a user in conversations.](https://github-production-user-asset-6210df.s3.amazonaws.com/83146190/261158402-5a79cc3e-4331-475f-8063-5ed81fefcf10.gif) - [](# "table-input") [Adds a button in the text editor to quickly insert a simplified HTML table.](https://user-images.githubusercontent.com/46634000/94559114-09892c00-0261-11eb-8fb0-c5a85ea76b6f.gif) diff --git a/source/features/minimize-upload-bar.css b/source/features/minimize-upload-bar.css deleted file mode 100644 index b511bff3ec5..00000000000 --- a/source/features/minimize-upload-bar.css +++ /dev/null @@ -1,26 +0,0 @@ -/* `.js-upload-markdown-image` excludes non-comment attachment drop areas. See #2086 */ -/* `:not(.js-comment-update)` excludes comment edition forms, as they lack the upload image button. See #4542 */ -[rgh-minimize-upload-bar] - form:not(.js-comment-update) - .js-upload-markdown-image.is-default - .drag-and-drop { - display: none !important; -} - -[rgh-minimize-upload-bar] - form:not(.js-comment-update) - .js-upload-markdown-image.is-default - textarea { - border-bottom-style: solid; - border-radius: 6px; -} - -/* Show upload image button in PR minimized upload bar for desktop */ -@media (min-width: 768px) { - [rgh-minimize-upload-bar] - .js-previewable-comment-form - label[aria-label^='Attach an image'] { - display: block !important; - padding: 4px !important; - } -} diff --git a/source/features/minimize-upload-bar.tsx b/source/features/minimize-upload-bar.tsx deleted file mode 100644 index 75464565034..00000000000 --- a/source/features/minimize-upload-bar.tsx +++ /dev/null @@ -1,6 +0,0 @@ -import './minimize-upload-bar.css'; -import * as pageDetect from 'github-url-detection'; - -import features from '../feature-manager.js'; - -void features.addCssFeature(import.meta.url, [pageDetect.hasRichTextEditor]); diff --git a/source/refined-github.ts b/source/refined-github.ts index aa2a82887c8..4d4f54fe5b4 100644 --- a/source/refined-github.ts +++ b/source/refined-github.ts @@ -29,7 +29,6 @@ import './features/mark-private-repos.css'; import './features/align-issue-labels.js'; import './features/clean-pinned-issues.js'; import './features/hide-newsfeed-noise.js'; -import './features/minimize-upload-bar.js'; import './features/hide-diff-signs.js'; import './features/clean-rich-text-editor.js';