Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isRepoRoot() return false if the repository doesn’t have a description #189

Open
hawkup opened this issue Feb 15, 2024 · 0 comments
Open
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@hawkup
Copy link

hawkup commented Feb 15, 2024

If you open the repository URL on the default branch tree (tree/main) and run isRepoRoot() without providing a URL, the isRepoRoot() function always returns false.

case 1: isRepoRoot() return false

URL: https://github.com/Shopify/function-examples/tree/main

Log context:

"getRepo()": {
	name: "function-examples",
	nameWithOwner: "Shopify/function-examples",
	owner: "Shopify",
	path: "tree/main"
},
"document.title": "Shopify/function-examples",

case 2: This works fine. isRepoRoot() return true

URL: https://github.com/Shopify/function-examples

Log context:

"getRepo()": {
	name: "function-examples",
	nameWithOwner: "Shopify/function-examples",
	owner: "Shopify",
	path: ""
},
"document.title": "Shopify/function-examples"

case 3: This works fine. isRepoRoot() return true

URL: https://github.com/Shopify/function-examples/tree/order-routing-js-template

Log context:

"getRepo()": {
	name: "function-examples",
	nameWithOwner: "Shopify/function-examples",
	owner: "Shopify",
	path: "tree/order-routing-js-template"
},
"document.title": "Shopify/function-examples at order-routing-js-template"
@fregante fregante added bug Something isn't working help wanted Extra attention is needed labels Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Development

No branches or pull requests

2 participants