Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tutorial] Reactions update is broken in <SinglePostPage /> #4375

Open
dpyzo0o opened this issue Jun 17, 2022 · 6 comments
Open

[tutorial] Reactions update is broken in <SinglePostPage /> #4375

dpyzo0o opened this issue Jun 17, 2022 · 6 comments
Labels

Comments

@dpyzo0o
Copy link

dpyzo0o commented Jun 17, 2022

Steps To Reproduce

  1. Click "View Post" for any post
  2. Click the reactions

Link to code example: The codesandbox here

The current behavior

Reactions work for the post list page, not for the single post page.

The expected behavior

  1. Reactions work for single post page
  2. Reactions sync in both list list page and single post page.
@markerikson markerikson transferred this issue from reduxjs/redux-toolkit Jun 17, 2022
@dannielss
Copy link

dannielss commented Jun 28, 2022

I did an update on apiSlice.js and everything is working fine:

The codesandbox here

@dannielss
Copy link

@markerikson How I can update the codesandbox example?

@markerikson
Copy link
Contributor

@dannielss It's... kinda complicated :)

All the sandboxes live in https://github.com/reduxjs/redux-essentials-example-app . Specifically, it's the tutorial-steps branch, with tags applied to specific commits.

To update the sandboxes, you'd actually have to:

  • Clone the repo
  • Check out the tutorial-steps branch
  • Reset the branch all the way to the last commit that added/changed these lines
  • Alter the commit
  • Cherry-pick all commits after that
  • Change all tags to point to the new commits in the branch
  • Force-push it

So, unfortunately not easy, and not something other folks can do atm either

@MubashirWaheed
Copy link

I started learning redux using docs but unfortunately sandbox examples are broken

@markerikson
Copy link
Contributor

@MubashirWaheed : what parts of the sandboxes are broken, specifically?

@MubashirWaheed
Copy link

Code sandbox for the "basic redux dataflow" under the redux essential is not working on firefox but I just checked and it is working fine chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants