-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kombu SQS Compatibility #423
Comments
I'm looking at Qasim's docs on how he sets up the SQS consumers and it looks like he's passing a hostname of |
I'll have to go back and look, but when I last talked to him, he was explicitly creating a |
@isugimpy did you ever find out if there's more for us to do here? or can this be closed out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the
connection_from_config
method is very AMQP focused. Kombu has underlying support for AWS SQS, but our wrapper to generate connections is unable to take advantage of it becausehostname
is a required field on the call, but is incompatible with SQS queue URLs in the Kombu SQS implementation. My thought on this is to add an optional arg toconnection_from_config
to indicate that the queue is SQS (or maybe a list of known strings for different behavior, defaulting to AMQP if the arg isn't specified), and alter the config parser to makehostname
optional in that scenario. Would there be another preferred way to implement this?This isn't fully blocking usage of SQS in baseplate, as engineers can simply create a
Connection
manually.The text was updated successfully, but these errors were encountered: