Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] inconsistent dependency on Pymanopt #2038

Open
SimonYansenZhao opened this issue Nov 13, 2023 · 2 comments
Open

[BUG] inconsistent dependency on Pymanopt #2038

SimonYansenZhao opened this issue Nov 13, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@SimonYansenZhao
Copy link
Collaborator

Description

In setup.py, pymanopt is required as a dependent package:

extras_require["experimental"] = [
    # xlearn requires cmake to be pre-installed
    "xlearn==0.40a1",
    # VW C++ binary needs to be installed manually for some code to work
    "vowpalwabbit>=8.9.0,<9",
    # nni needs to be upgraded
    "nni==1.5",
    "pymanopt>=0.2.5",
]

However, in tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py, pymanopt is replaced:

    conda_dep.add_pip_package(
        "pymanopt@https://github.com/pymanopt/pymanopt/archive/fb36a272cdeecb21992cfd9271eb82baafeb316d.zip"
    )

This inconsistency may cause problems in the future, and complicate testing.

In which platform does it happen?

This behavior only happens in testing.

How do we replicate the issue?

Triggering a test will make it happen.

Expected behavior (i.e. solution)

Testing should not change the dependencies of the recommenders package.

Other Comments

@SimonYansenZhao SimonYansenZhao added the bug Something isn't working label Nov 13, 2023
@SimonYansenZhao
Copy link
Collaborator Author

Some modules were renamed in the new version of Pymanopt, such as pymanopt.solvers. See pymanopt/pymanopt#207

@miguelgfierro
Copy link
Collaborator

Related to #1943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants