Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Add Markers for Charts #71

Open
amcdnl opened this issue May 19, 2022 · 0 comments
Open

Ability to Add Markers for Charts #71

amcdnl opened this issue May 19, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@amcdnl
Copy link
Member

amcdnl commented May 19, 2022

Requirement

Add the ability to put a 'marker' in charts.

Let's add the following charts ( Linear only ) :

  • Line
  • Area
  • Bar ( Horz/Vertial )
  • Scatter

NOTE: There is already a MarkLine ( https://github.com/reaviz/reaviz/tree/master/src/common/MarkLine ) which is different front this. Its more of a marker that follows the cursor so perhaps in this change we should rename that or consolidate these? Also MarkLine isn't great name since it includes Line which it could potentially be something else. Maybe CursorMarker?

Example API

<AreaChart
  series={
    <AreaSeries
      markers={[
        <Marker
          value={50}
          color="blue"
          label={
            <MarkerLabel
              color="white"
              position="center"
              text="Goal 900k"
            />
        }
      />
    ]}
  />}
/>

I realize the label API is a bit overkill but its needed to add more complex options. It also needs to account for the direction/scale.

Example UI

image

@amcdnl amcdnl added the enhancement New feature or request label May 19, 2022
@amcdnl amcdnl self-assigned this May 19, 2022
@AdminAkai AdminAkai mentioned this issue Sep 27, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant