-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to Add Markers for Charts #71
Labels
enhancement
New feature or request
Comments
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Requirement
Add the ability to put a 'marker' in charts.
Let's add the following charts ( Linear only ) :
NOTE: There is already a
MarkLine
( https://github.com/reaviz/reaviz/tree/master/src/common/MarkLine ) which is different front this. Its more of a marker that follows the cursor so perhaps in this change we should rename that or consolidate these? AlsoMarkLine
isn't great name since it includesLine
which it could potentially be something else. MaybeCursorMarker
?Example API
I realize the label API is a bit overkill but its needed to add more complex options. It also needs to account for the direction/scale.
Example UI
The text was updated successfully, but these errors were encountered: