-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "custom children" in uppercase components #822
Comments
This will force all usages of children to be either fragments, or wrapped in React.array. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consider the following component:
An a usage:
This fails with
The reason is that the PPX compiles the above into:
And
React.array
expects (correctly) an array of elements as input.I wonder if the PPX could skip the call to
React.array
for elements that are produced using custom components (i.e. the upper case ones)? In those cases, the component author has full control, so if they pass an array, we can allow the type inside the array to be anything, really.The text was updated successfully, but these errors were encountered: