Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GraphiQL.re from graphql template to morph-server-graphql #24

Open
baransu opened this issue Oct 29, 2019 · 3 comments
Open

Move GraphiQL.re from graphql template to morph-server-graphql #24

baransu opened this issue Oct 29, 2019 · 3 comments

Comments

@baransu
Copy link

baransu commented Oct 29, 2019

It would be great to provide ~graphiql: bool option to Morph_graphql_server.make or provide something like Morph.Response.text(Library.GraphiQL.html, Morph.Response.empty) available from Morph_graphql_server module

/ cc @cem2ran

@cem2ran
Copy link

cem2ran commented Oct 29, 2019

Would be great!

Some more (powerful) options:

I added GraphiQL as it was the easiest and quickest, but worth considering whether one should allow this to be a bit more configurable. Should it just be a url or should it just be yet another middleware? @ulrikstrid

@baransu
Copy link
Author

baransu commented Oct 29, 2019

Another option is to point users to standalone GraphQL clients like:

instead of providing GraphiQL middleware.

I'm personally using Altair and none of my projects expose GraphiQL.

@ulrikstrid
Copy link
Collaborator

I think that this is a documentation problem basically. I like that graphiql (or any derivative) is provided in the pesy template because it's really powerful to have there. But I'm not sure we want to integrate it into the the library.
I'm not against it, I'm just not sure we want to do it since it can feel like "lock in" to that particular implementation. We also have to keep it up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants