Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the requirement for macOS 12 or later? #130

Open
adamski opened this issue Dec 7, 2023 · 9 comments
Open

Why the requirement for macOS 12 or later? #130

adamski opened this issue Dec 7, 2023 · 9 comments
Assignees

Comments

@adamski
Copy link

adamski commented Dec 7, 2023

I'm concerned that requiring macOS 12 will exclude a sizeable chunk of my customers.

Some data from another vendor in our industry (audio plugins):

macOS 10.x = 31%
macOS 11   = 8%
macOS 12   = 23%
macOS 13   = 25%
macOS 14   = 10%

Assuming this data also represents my customers, I'd potentially be excluding 39% of them by forcing this requirement. A lot of music producers will stay on older macOS versions for various reasons.

Can you please explain why this requirement is necessary, and if there is a way to reduce it, ideally back to Catalina or Mojave?

Thank you

@adamski
Copy link
Author

adamski commented Dec 7, 2023

Actually I just tried building for 10.15 Catalina and it builds fine.

It seems that the only issue in supporting earlier versions is the use of C++17 std::filesystem::path which requires 10.15 or later.

May I propose to use this header-only library to replace it, which will enable lower versions to be supported (tested down to 10.12): https://github.com/gulrak/filesystem

This would enable me to continue to serve all of my current customers without excluding those on older hardware / not willing to update.

@leemaguire
Copy link
Contributor

@adamski we currently only test as low as macOS 12 and that is the reason for it being the minimum supported version. We can setup more CI actions to test against older macOS versions which should help you here.

@adamski
Copy link
Author

adamski commented Dec 11, 2023

Thank you. Would you consider using the library linked above to open it up for lower macOS versions than 10.15?

I could create a PR if it helps?

@leemaguire
Copy link
Contributor

@adamski I'll see if there's a way to do this without the need for a 3rd party lib.

Copy link

sync-by-unito bot commented Feb 9, 2024

➤ Kenneth Geisshirt commented:

We need to test on GHA with more versions of MacOS.

@adamski
Copy link
Author

adamski commented May 7, 2024

@leemaguire any update on this issue?

@kneth
Copy link
Member

kneth commented May 8, 2024

@adamski I'll discuss it with Lee when he is back next week.

@leemaguire
Copy link
Contributor

@adamski I'll add the ability for our CI to test the lowest possible deployment target. Currently the lowest macOS version that I can build and test locally successfully is 10.15.

@adamski
Copy link
Author

adamski commented May 24, 2024

@adamski I'll add the ability for our CI to test the lowest possible deployment target. Currently the lowest macOS version that I can build and test locally successfully is 10.15.

10.15 is totally fine, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants