Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any issues that you encountered with skate ssr? #4

Open
trusktr opened this issue Jul 8, 2020 · 2 comments
Open

Any issues that you encountered with skate ssr? #4

trusktr opened this issue Jul 8, 2020 · 2 comments

Comments

@trusktr
Copy link

trusktr commented Jul 8, 2020

Curious to know what limitations you encountered with Skate SSR. I'd like to circle back to SSR at some point with lume/element.

@steveblue
Copy link
Collaborator

steveblue commented Jul 9, 2020

The @skatejs/ssr package could be falling out of maintenance, last publish was 2 years ago.

There was a slight hiccup when pairing the ssr package with Readymade.

The ssr package injects a call to a function called __ssr in the server side rendered template that is returned by the render() function. That function didn't exist or I looked at the implementation and said whatevs, so I had to postprocess the template. See here.

It's maybe a good time for someone to make an ESM equivalent that is framework agnostic, but for now it does the job.

The package is fast, I'll give it that. Looking into the source it seems there are opportunities to make how it walks the DOM more performant.

@trusktr
Copy link
Author

trusktr commented Sep 8, 2020

render()

Ah, I see, it was expecting a SkateJS-specific method. So you did your own thing there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants