Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the unit tests to be functional for the adapters, instead of mocking them, to test their implementation - not the expected stacktrace. This PR also changes some other things, such as:
new FulfilledPromise
->React\Promise\resolve
new RejectedPromise
->React\Promise\reject
count
anymore for the file descriptor - instead one will be generated using PHP7's random bytes APIls
has been made to use a promise, instead of a stream (made compatible to the interface)symlink
have been renamed to be not ambiguous anymoreCharlotteDunois/Phoebe
for pthreads pool with messaging and event looped workerThe PR commits will be squashed once review is positive. This PR includes and closes #46.