Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: No new lines in error decoder errors #6734

Open
rickhanlonii opened this issue Apr 5, 2024 · 4 comments · May be fixed by #6767
Open

[Bug]: No new lines in error decoder errors #6734

rickhanlonii opened this issue Apr 5, 2024 · 4 comments · May be fixed by #6767
Labels
bug: confirmed good first issue

Comments

@rickhanlonii
Copy link
Member

Summary

Check out this error: https://react.dev/errors/418

It's formatted all on one line, but should have new lines.

Page

https://react.dev/errors/418

Details

No response
@wheeler6123
Copy link
Contributor

Hi, could you please assign this issue to me? I submitted a pull request separately and signed the CLA. Thank you

@wheeler6123
Copy link
Contributor

@rickhanlonii Good morning Ricky, just wanted to follow up on this issue, I submitted a pull request under #6735 and wasn't sure if there was any feedback for my proposed solution. Thanks!

rickhanlonii pushed a commit that referenced this issue Apr 17, 2024
@wheeler6123
fix issue #6734 (#6735)
c2180a3 
* in \[errorCode\].tsx, wrapped parsedContent in a div and applied styling of white-space: pre-wrap to preserve whitespace and break on newline chars

* updated styling to tailwind class
@eps1lon
Copy link
Collaborator

eps1lon commented Apr 20, 2024

Seems to include newlines now:

Screenshot 2024-04-20 at 21 35 19

-- https://react.dev/errors/418

The only thing missing is handling empty strings. The hydration errors will always produce https://react.dev/errors/418?args[]= but that's interpreted as missing unfortunately.

@eps1lon eps1lon linked a pull request Apr 20, 2024 that will close this issue
Open
@eps1lon eps1lon linked a pull request Apr 20, 2024 that will close this issue
/errors: Empty args are not missing arguments #6767
Open
@eps1lon
Copy link
Collaborator

eps1lon commented Apr 20, 2024 •
edited

I could reproduce it locally though it wasn't consistent. Should be fixed with #6767. #6735 didn't seem to fix this locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: confirmed good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

/errors: Empty args are not missing arguments eps1lon/reactjs.org
3 participants
@rickhanlonii @eps1lon @wheeler6123