-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DISCUSSION] Type Namespacing/Collision #25
Comments
OP: If two federated services register a type, query, or mutation with the same name, the gateway errors out upon startup. Issue for this: https://github.com/apollographql/apollo-server/issues/3186. Colliding scalars work as of apollographql/apollo-server#2767. We have come up with multiple decisions and chose to manually prefix our services with namespaces, as exemplified in the issue @kieckhafer linked above. Although the other solutions are not acceptable for us, we will be writing up a decision record for this choice. |
@rosshadden @kieckhafer the description for this issue is blank. Could you provide specific details for why we're getting collisions? Is that generalizable? I'll describe below but I'm not sure I understood the "why" behind #132. I read #132 and made some suggestions, to which @eric replied:
I agree with the comment. I wasn't suggesting to prefix with a plugin name. I thought the problem is that the authorization service is introducing a new type of policy. The new policy is different from a previously existing Reaction API Did I miss the ⛵? |
If two federated services register a type, query, or mutation with the same name, the gateway errors out upon startup. Issue for this: apollographql/apollo-server#3186.
Colliding scalars work as of apollographql/apollo-server#2767.
We have come up with multiple decisions and chose to manually prefix our services with namespaces, as exemplified in the issue @kieckhafer linked above. Although the other solutions are not acceptable for us, we will be writing up a decision record for this choice.
The text was updated successfully, but these errors were encountered: