New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Era - Contributors! #926
Comments
Great news! |
Thanks @choonkending I think you are doing a good job, and I will be happy to help out where I can. There have been a lot of interesting advancements of technical and conceptual aspects of React lately which we can discuss and potentially implement. I agree with @slavba89 though, first focus should be resolving community and tech debt. Also the documentation needs some love. For example, the roadmap might not be very up to date ;) |
Great! I'm little busy these days, but I think I still can contribute to this project. |
@ZeroCho tell me about it! Let's be careful not to turn this this relatively non complex project into UniversialReactRouterReduxImmutableJSReselectGraphQLRelayGo 😆 (not saying we won't, but let's take it a bit easy lol) |
@ZeroCho have you tried redux-logic https://github.com/jeffbski/redux-logic ? What do you think about this? |
@againksy There was a talk about different side-effect handlers before Regarding the stack of this project, we'll need to see what we leave, what we take out and how do we structure stuff. It is obviously opinionated to some point but the idea is to make it as simple as we can for people to start working with it. For example, if i dont need SSR then i'll do a couple of changes and its gone. If i dont need codesplit, couple of changes and its gone. If i have to over 15 files in order to remove/add a feature or a module then in my opinion its not robust/modular/whatever enough. For instance, we currently follow the "official" redux suggestion of structuring actions, reducers, types and selectors. Some of you may have heard about the |
So i've gone and cleaned the project as much as i could (Some people might hate me for closing their issue but it can always be reopened 😄 )
We also need to tackle all the open PR's that we have. Some of them overlap (the codesplit, ssr ones) so we need to decide to which direction we're going. |
@slavab89 very awesome good work!
This should probably be the very first thing we do. To make it as easy as possible for the people who have opened the PRs, we should probably start with the least invasive ones first. Like minor improvements, bug fixes (if there are any), and then tackle the larger architectural ones. |
Just in case folks haven't made it clear - I want to thank all of you (especially @choonkending ) for bringing the project this far and offer my appreciation that you guys are stepping up to help maintain this project. This one is a diamond in the rough! |
Hey peeps, I think I haven't been doing a good job to ensure that reactGo is up to date. I have been focusing on other aspects of work (and life) and it's hard to carve out time to work on reactGo.
There are PRs hanging around that I block without ever merging it. It can be frustrating as a contributor if the maintainer does not respond.
I've made @ZeroCho, @GGAlanSmithee and @slavab89 admins of reactGo so that you can be free to make the improvements you see fit! You peeps have been constantly contributing and I really appreciate the hard work you've put in.
I'll still hang around and contribute when I have the capacity, but I think this repo can have a lot more love if you peeps are around to improve it. Let me know if you require more access!
The text was updated successfully, but these errors were encountered: