-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing TSLint with ESLint in react-native's source? #719
Comments
For someone who hasn't been following |
Yes! We're going to have to add that to DefinitelyTyped's usage of |
Introduction
馃憢 Hi! I'm one of the maintainers of typescript-eslint and was one of the maintainers of TSLint, which is now deprecated in favor of typescript-eslint. Following up on DefinitelyTyped/DefinitelyTyped#66351 (comment): I see there's a
tslint.json
file in the react-native repository: https://github.com/facebook/react-native/blob/87dbe44db4f211b3cd5f4ed8fc5ad7ee059ff2ba/packages/react-native/types/tslint.json.Looks like it's there primary for dtslint: https://github.com/facebook/react-native/blob/87dbe44db4f211b3cd5f4ed8fc5ad7ee059ff2ba/package.json#L35-L36
Would you be open to a PR that migrates from TSLint to ESLint?
Details
TSLint is deprecated and hasn't received updates for the latest versions of TypeScript in several years. We've mostly replaced its rules in dtslint with ESLint equivalents: microsoft/DefinitelyTyped-tools#648. At this point the only rule that isn't explicitly converted over are
expect-type
(see https://github.com/JoshuaKGoldberg/eslint-plugin-expect-type) andnpm-naming
(microsoft/DefinitelyTyped-tools#681, and not relevant here?).Discussion points
I couldn't figure out a good place for this in the core react-native repository. Sorry if this issue template wasn't the right one. 馃檪
The text was updated successfully, but these errors were encountered: