Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useContainerQuery hook typings are loose/wrong #98

Open
callumlocke opened this issue May 5, 2021 · 1 comment
Open

useContainerQuery hook typings are loose/wrong #98

callumlocke opened this issue May 5, 2021 · 1 comment

Comments

@callumlocke
Copy link

callumlocke commented May 5, 2021

This library looks great, but I'm having a bit of trouble with its included typings. The useContainerQuery hook returns any[], but in reality it seems to always return a tuple of two specific types.

Is there any reason why useContainerQuery hook can't have its return value typed more precisely, something like [Params, React.Ref]?

Also, the second argument (initialSize) is required by the typings, but the readme examples and the source suggest that it isn't required IRL.

@callumlocke callumlocke changed the title useContainerQuery hook return value is typed: any[] useContainerQuery hook typings are loose/wrong May 5, 2021
@akafaneh
Copy link

akafaneh commented Sep 1, 2021

+1 one on that
Does the library maintainers accept PRs? if yes i can do a fix for this. or some of it at least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants