[fixed] Add missed propType validation for Button 'type' property

react-bootstrap · Jun 30, 2015 · 89ea6ed · 89ea6ed
1 parent 557e470
commit 89ea6ed
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/Button.js b/src/Button.js
@@ -2,6 +2,7 @@ import React from 'react';
 import classNames from 'classnames';
 import BootstrapMixin from './BootstrapMixin';
 import CustomPropTypes from './utils/CustomPropTypes';
+import ButtonInput from './ButtonInput';
 
 const Button = React.createClass({
  mixins: [BootstrapMixin],
@@ -14,14 +15,18 @@ const Button = React.createClass({
  navDropdown: React.PropTypes.bool,
  componentClass: CustomPropTypes.elementType,
  href: React.PropTypes.string,
- target: React.PropTypes.string
+ target: React.PropTypes.string,
+ /**
+ * Defines HTML button type Attribute
+ * @type {("button"|"reset"|"submit")}
+ */
+ type: React.PropTypes.oneOf(ButtonInput.types)
  },
 
  getDefaultProps() {
  return {
  bsClass: 'button',
- bsStyle: 'default',
- type: 'button'
+ bsStyle: 'default'
  };
  },
 
@@ -68,6 +73,7 @@ const Button = React.createClass({
  return (
  <Component
  {...this.props}
+ type={this.props.type || 'button'}
  className={classNames(this.props.className, classes)}>
  {this.props.children}
  </Component>