Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature ideas/wishes (remaining: transparent window background) #26

Open
wayfu opened this issue Sep 6, 2021 · 8 comments
Open

Feature ideas/wishes (remaining: transparent window background) #26

wayfu opened this issue Sep 6, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@wayfu
Copy link

wayfu commented Sep 6, 2021

Thank you for making this tool available! I have been using it for a while now, and it has been very helpful. There are two things that I have found myself wishing for a few times:

  1. It would be great if BeeRef remembered its window settings between sessions - always on top, menu bar/title bar visibility
  2. It would be incredibly awesome if there were a way to make the background transparent (and possibly even to hand down clicks in the transparent parts of the app to what's below when set to always on top
@rbreu rbreu added the enhancement New feature or request label Sep 7, 2021
@rbreu
Copy link
Owner

rbreu commented Sep 7, 2021

Menu bar visibility should already be saved and restored. If it doesn't, there's something strange going on in your case. Do recent files get remembered in the File -> Recent Files menu?

With title bars and Always on Top, I'd like create a settings dialog first so that the user has to explicitly enable remembering those. I just haven't gotten around to that yet.

Regarding 2., yeah, that's already on my list, too. I'll have to see what Qt lets me do in that regard.

@wayfu
Copy link
Author

wayfu commented Sep 7, 2021

I do get Recent Files, yes. Some more experimenting also showed that BeeRef does remember the visibility of the menu bar and the scroll bars, but not of the title bar, nor the always on top or fullscreen status.

@rbreu
Copy link
Owner

rbreu commented Sep 7, 2021

Okay, then that's working as I coded it. ;)

@wayfu
Copy link
Author

wayfu commented Sep 7, 2021

haha fair enough :D

@andrsd
Copy link
Contributor

andrsd commented Sep 20, 2021

I coded up the feature of saving and restoring the main window geometry (location, size, etc.). It does it for the application window, but I am thinking it would may be make more sense to store this per file.

What do you guys think?

@rbreu
Copy link
Owner

rbreu commented Sep 29, 2021

Is this common to go by file? I don't remember encountering something like that, but this might just be me. I'd rather go with the most common option, I think.

Regarding restoring of location and size: You have to be careful when the user switches screen resolutions/monitors/external monitors/screen orientation in the meantime and ensure that the window doesn't end up outside of the screen, or bigger than the screen, or on an external monitor that's not plugged in anymore.

@andrsd
Copy link
Contributor

andrsd commented Oct 10, 2021

Saving application window geometry is more common option (IMO). Files can be transferred between machines and preserving geometry might be much harder - as you pointed out. The reason why I mentioned the possibility to save it into a file was that you can think about the application window like a canvas with all your pictures - then you may want to preserve such geometry per file rather then preserving the geometry for all files. If that makes sense.

As a note. If you are on a Mac OS X and your window is way off your screen, the OS will move it such that you can grab it and reposition. IDK if this is a thing on Windows and Linux - I don't use them enough :-(

The branch with this feature is on my save-main-win-goemetry branch. Feel free to pull it or cherry-pick it, if you want to add it to the main branch. Or I can open a pull request...

@rbreu
Copy link
Owner

rbreu commented Oct 13, 2021

Hi! I've tested you code on Linux and not managed to break anything. It seems from the docs that Qt is taking care of things not getting off-screen, so I trust it will work on Windows, too, though I will give it a bit of a test when I prepare the release just in case.

Would you open a pull-request? I have a couple of remarks.

@rbreu rbreu changed the title Feature ideas/wishes Feature ideas/wishes (remaining: transparent window background) Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants