Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.12.0 high resource usage and slow autocomplete #151

Closed
DanielViberg opened this issue Apr 22, 2024 · 10 comments
Closed

Version 0.12.0 high resource usage and slow autocomplete #151

DanielViberg opened this issue Apr 22, 2024 · 10 comments

Comments

@DanielViberg
Copy link

DanielViberg commented Apr 22, 2024

Hello,

Nice job on this c-sharp server.

Since version 0.12.0 i'm seeing high cpu usage and slow auto complete:
image
The machine is a windows 10 64bit, running vim in powershell.
If i downgrade to version 0.11.0 the problem disappears.

@razzmatazz
Copy link
Owner

Hey @DanielViberg

Could you try backing out this commit: ada53cd and then recompile from source?

It can be either this commit (roslyn upgrade) or something else–it may be time to add option to dump request stats to stderr to find which endpoint in particular is slow.

@AbrA-K
Copy link

AbrA-K commented Apr 24, 2024

Have the same issue (where version 0.11.0 was a LOT faster).
I have trouble building building the lsp for testing this. dotnet build on the Project root will build it and the binary will be in <Projectroot>/src/CSharpLanguageServer/bin/Debug/net8.0/CSharpLanguageServer, correct?
(another thing: I'm using the dotnet-sdk-8.0.104 and not 8.0.200 - this should not be a big deal, right?)

@DanielViberg
Copy link
Author

Im currenly not near my dev machine. I'll get back to you as soon as i get back!

@DmitryHudrich
Copy link

DmitryHudrich commented Apr 28, 2024

Hi, i have same problem and i compiled lsp from last commit. i just replaced roslyn version to 4.7.0, but the problem still remains so i think the problem is not roslyn.
I went back to the ada53cd commit and changed the roslyn version to the newest one. now I have c#12 support with the right performance

@DmitryHudrich
Copy link

a117ea is the commit that caused the problem. everything works fine before him.
lsp already supports the twelfth version of the language here, but I don't see any performance problems.

@razzmatazz
Copy link
Owner

a117ea is the commit that caused the problem. everything works fine before him. lsp already supports the twelfth version of the language here, but I don't see any performance problems.

Thank you for triaging this! I will investigate this further

@razzmatazz
Copy link
Owner

razzmatazz commented May 1, 2024

Should be fixed in f6ce285

I will release a new version later this week.

@j0of
Copy link

j0of commented May 7, 2024

Has this issue been resolved for anyone yet? I am also having this problem but I'm unsure if the patch has already been released

@razzmatazz
Copy link
Owner

Has this issue been resolved for anyone yet? I am also having this problem but I'm unsure if the patch has already been released

I did not release a bugfix release yet -- trying to figure out if I can make it even faster by disabling autocomplete from non-imported namespaces.

@razzmatazz
Copy link
Owner

0.13.0 has been released which should fix the issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants