Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper scaling #21

Open
anoojpatel opened this issue Sep 5, 2018 · 1 comment
Open

Improper scaling #21

anoojpatel opened this issue Sep 5, 2018 · 1 comment

Comments

@anoojpatel
Copy link

I believe your scale_data() is scaling horizontally across the signals rather than down the time series for each of signal itself. I used:

def scale_linear_bycolumn(rawpoints, high=1.0, low=-1.0):
mins = np.min(rawpoints, axis=0)
maxs = np.max(rawpoints, axis=0)
rng = maxs - mins
return high - (((high - low) * (maxs - rawpoints)) / rng)

I think it would make sense to scale the whole signals's timeseries (down the column) rather than across at each time step. I noticed this when I was inputing signals with different amplitudes and the values starting to fill as NaN because it was being scaled across signals at a timestep rather than down the signal to all the values for that signal's time series.

@data-boss
Copy link

Hi,

I'm also trying to train the RGAN to reproduce the results on the eICU data. I have not got the eICU dataset, could you give me a brief introduction abot the structure of the dataset?
what are the 7 lables in the manuscript?
thank you

contact me : [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants