-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typoe Ch4 - Page 136 #90
Labels
fixed-in-3rd-edition
Tagged as fixed in the upcoming 3rd edition
Comments
Thanks for the note! In my version, it's not indices = np.argsort(importances[::-1]) but indices = np.argsort(importances)[::-1] which would be similar to what you suggested with When I remember correctly, Packt had briefly an unedited version online in ~2017 that contained that issue, but it should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
indices = np.argsort(importances[::-1]) # this causes the wrong order for plt.show() at the end of the code chunk (though the values are correct)
indices = importances.argsort()[::-1] # gives correct order
in the remote chance that this was a legit issue, It would be a privilege to be mentioned!
The text was updated successfully, but these errors were encountered: