-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapter 16 typo #108
Comments
Thank you @rickiepark for your comments. You are right on both statements, it should be « at time t » and the last index should be 2499. We will make a note of these for the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(p546) In a note, "Since the loss at time 1:t is dependent on the hidden units at all previous time steps 1:t" may be "Since the loss at time t is dependent on the hidden units at all previous time steps 1:t-1".
(p555) In middle code block,
As you may know, pandas' dataframe slicing includes start and end index.
Actually it is not a problem with this example, but I think it's better to change
y_train = df.loc[:24999, 'sentiment'].values
.Thanks.
The text was updated successfully, but these errors were encountered: