Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Loss of Selections After Search #1702

Open
gbaltazar opened this issue Apr 22, 2024 · 3 comments
Open

[Bug]: Loss of Selections After Search #1702

gbaltazar opened this issue Apr 22, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@gbaltazar
Copy link

What happened?

Error description: I'm making a multiple selection of items to later perform a Bulk operation with them. I select a first item, then perform a search to select the second one, but the previous selection I had made is cleared.

How to reproduce the bug

I first try searching for the items I want to select, choose one of them, then upon searching to select another, the previous selection is erased. Is it possible to maintain the selection I had made after performing a search in the component?

Package Version

2.15

PHP Version

8.1.x

Laravel Version

10.0

Alpine Version

3.13.9

Theme

Bootstrap 4.x

Notes

No response

Error Message

No response

@gbaltazar gbaltazar added the bug Something isn't working label Apr 22, 2024
@ivanmar01
Copy link

I can confirm that bug exists also in latest v3 version.

@lrljoe
Copy link
Sponsor Collaborator

lrljoe commented Jun 7, 2024

@gbaltazar @ivanmar01 - To be honest, it's more intentional than being a bug.

Having something "selected" via the Bulk Action checkboxes, but not visible seems odd to my mind.

E.g. you select the user "Bob" (who lives in "France") after searching for users "Bo", and filtering on Country of Residence.

Then you change the filter, for users who live in "Japan", and search for "Rich" in the name.
Having "Bob" still selected, despite not being visible (and thus not deselectable) seems like not great UX.

If there's something I'm missing, then we can look at adding in a config option to enable/disable a different behaviour, but would need to know how widespread the desire is for it so that I can prioritise it.

@lrljoe
Copy link
Sponsor Collaborator

lrljoe commented Jun 7, 2024

Quick update, I've added in some toggles, but it'll be at least a week (ish) for it to make it into v3, as I need to write tests & docs for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants