Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle Ctrl-c and Escape #49

Open
ineu opened this issue Oct 8, 2021 · 5 comments
Open

Gracefully handle Ctrl-c and Escape #49

ineu opened this issue Oct 8, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@ineu
Copy link

ineu commented Oct 8, 2021

First of all I'd like to thank for the convenient tool to pick themes. There are some issues I've discovered:
1: The app incorrectly handles Ctrl-c:

  1. Run alacritty-themes
  2. Move to the next theme and quickly press Ctrl-c
    If the interrupt sequence is pressed fast enough, it catches the app in the middle of writing to alacritty.yml, leaving it half-written. The result is the broken config:
    изображение

The app should trap C-c and finish the cleanup first

2: The app incorrectly handles Esc:

  1. Run alacritty-themes
  2. Move to a theme
  3. Press Esc
    Expected: the selection process aborts, leaving the previous theme
    Actual: a theme under cursor is applied like if Enter was pressed.
@rajasegar rajasegar added the bug Something isn't working label Oct 8, 2021
@JuanVqz
Copy link
Collaborator

JuanVqz commented Oct 8, 2021

@rajasegar what do you think about adding a hacktoberfest label? it could help many people know about alacritty-themes.

@rajasegar
Copy link
Owner

Sounds good to me

@JuanVqz JuanVqz added the hacktoberfest open source is changing the world label Oct 8, 2021
@rajasegar
Copy link
Owner

@JuanVqz Added the label to the repo as well

@JuanVqz
Copy link
Collaborator

JuanVqz commented Oct 9, 2021

you already did it, thank you, what else can we add with the hacktoberfest label? BTW I'm about to add a contributors section in the readme, are you agree?

@rajasegar
Copy link
Owner

Yes 👍

@JuanVqz JuanVqz removed the hacktoberfest open source is changing the world label Nov 2, 2021
@JuanVqz JuanVqz added the hacktoberfest open source is changing the world label Oct 6, 2022
@rajasegar rajasegar removed the hacktoberfest open source is changing the world label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants