Allow updating of app role by ignoring local_secret_ids
#336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 17, 2023 09:06
UpdateAppRoleRoleModel's job is to stop people from using `LocalSecretIds` when updating a role. This is not a valid property when updating a role and will result in an error on the API if using it Making the Obsolete attribute give a compiler error when using the property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #335 by creating a new Model for AppRole roles when updating a role.
When updating a role, we ignore the
LocalSecretIdsproperty from being serialized to json.As an extra measure; the compiler will throw an error when using
LocalSecretIdswhen using the update model.