Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple sessions per process #162

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Conversation

Dregu
Copy link

@Dregu Dregu commented Feb 22, 2024

When routing the W10 per-app audio output to a non-default device, some applications will open (inactive) sessions to multiple devices. Or some complex apps might do so on purpose. VC treats these sessions as duplicates even though they are on different outputs, which means only the first session can be adjusted, and it's usually the wrong one.

So I fixed that...

This PR:

Haven't tested this a lot, just what I have running currently, but then again there's not much to test. I also don't really know what I'm doing, so I might be doing something silly.

image
Some more clutter in the mixer, but not in the notification!

@Dregu
Copy link
Author

Dregu commented Feb 24, 2024

I also have a branch messing with active application / target override notifications where all affected sessions are always shown, even if the sessions are otherwise hidden. I had to reorganize how the hidden sessions are stored and filtered though, cause it seemed like a big mess to me to figure out which list a VM is supposed to be in. It's even more experimental...

@radj307
Copy link
Owner

radj307 commented Feb 29, 2024

This looks great so far! 👍

@Dregu
Copy link
Author

Dregu commented Mar 1, 2024

This looks great so far! 👍

I think so too! I've been rocking the active notifications for a week with no issues, except for the few corner cases with empty notification I just fixed, so that feature is also merged here now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants