Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Korean text isn't supported #16

Open
hahacandy opened this issue Jan 23, 2024 · 9 comments
Open

[BUG] Korean text isn't supported #16

hahacandy opened this issue Jan 23, 2024 · 9 comments
Assignees
Labels
bug Something isn't working game-specific Game-specific bugs that aren't caused by ARRCON.

Comments

@hahacandy
Copy link

hahacandy commented Jan 23, 2024

# System Information

  • OS: ubuntu
  • Version: 22.04
  • Shell (Windows-Only): bin sh

# Bug Description

When using rcon in palworld, korean is not displayed, and rcon is turned off when words containing korean are input or output.

# Reproduction Steps

@hahacandy hahacandy added the bug Something isn't working label Jan 23, 2024
@radj307
Copy link
Owner

radj307 commented Jan 24, 2024

Good catch!

I expect that this is an encoding issue; should be solvable by switching to wchars everywhere.
I will be looking further into this later today.

@radj307 radj307 changed the title [BUG] … [BUG] Korean text isn't supported Jan 24, 2024
@SelfEnough
Copy link

Chinese also

@ntanis-dev
Copy link

ntanis-dev commented Jan 27, 2024

Hi there, experiencing the same issue in Palworld where if a player has non-ASCII characters in their name "ShowPlayers" command will just hang indefinitely. Please let us know if we can assist you somehow in debugging this, or testing a dev branch. @radj307

Thank you!

@radj307
Copy link
Owner

radj307 commented Jan 28, 2024

@ntanis-dev currently working on this, but it'll take a little while.

@liasica
Copy link

liasica commented Jan 29, 2024

@ntanis-dev currently working on this, but it'll take a little while.

I think this is something that tools cannot solve. We can only hope that game developer group will be more compatible with non-English or non-Japanese characters.

@AustinGYF
Copy link

Good catch!

I expect that this is an encoding issue; should be solvable by switching to wchars everywhere. I will be looking further into this later today.

I suspect this is an inherent characteristic of the RCON protocol. If you have a read in the RCON document, it states that the RCON packet body is encoded in ASCIIZ.
However, within the same document, it also linked to a Java library which supports Chinese that non-ASCIIZ.

@liasica
Copy link

liasica commented Jan 30, 2024

Good catch!
I expect that this is an encoding issue; should be solvable by switching to wchars everywhere. I will be looking further into this later today.

I suspect this is an inherent characteristic of the RCON protocol. If you have a read in the RCON document, it states that the RCON packet body is encoded in ASCIIZ. However, within the same document, it also linked to a Java library which supports Chinese that non-ASCIIZ.

Palworld's RCON support for non-English or non-Japanese characters has bugs.

The RCON documentation says The packet body field is a null-terminated string encoded in ASCII (i.e. ASCIIZ)., NOT ALL body content needs to be ascii encoded.

For example, Simplified Chinese can be output normally, but this problem occurs because the game developer made an error in the coding and packaging calculation method.

RCON SUPPORT ALL LANGUAGES AND ALL CHARACTERS ˘¿˘

@radj307
Copy link
Owner

radj307 commented Jan 31, 2024

Related: #20

@radj307
Copy link
Owner

radj307 commented Jan 31, 2024

As @liasica said, the bug is most likely in PalWorld and not ARRCON in this case - at least partially, that is.

While the RCON protocol specifies that the packet body must be ASCII-encoded, there's no reason that the server/client can't correct it once received as any data sent over TCP is just bytes. TCP has no concept of encoding. For instance, if both the server and client support unicode over RCON, unicode characters can absolutely be sent and received.

After some testing that I did regarding #20, I discovered that even when non-ASCII text is forcibly sent via ARRCON, it appears as garbage text in-game.

@radj307 radj307 added the game-specific Game-specific bugs that aren't caused by ARRCON. label Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working game-specific Game-specific bugs that aren't caused by ARRCON.
Projects
None yet
Development

No branches or pull requests

6 participants