Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Popover in Tags Input with Combobox doesn't close when clicking outside. #410

Open
2 tasks
BroccoliBasti opened this issue Mar 13, 2024 · 2 comments
Open
2 tasks
Labels
bug Something isn't working

Comments

@BroccoliBasti
Copy link

Reproduction

https://stackblitz.com/edit/cku9c3?file=src%2FApp.vue

Describe the bug

When using the Tags Input with Combobox the popover doesn't close when you click outside of it, nor can it be closed by any other means. This issue is also present in the documentation page for Tags Input:
Popover issue

System Info

Tested in the latest versions of both Brave and Firefox.

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
@BroccoliBasti BroccoliBasti added the bug Something isn't working label Mar 13, 2024
@sadeghbarati
Copy link
Collaborator

@BroccoliBasti Hey just use dismissable on CommandList

For some reason, we decided to make the default dismissable prop in CommandList to false, until the new Listbox component arrives at the radix-vue

The reason was Popover already had DismissableLayer and CommandList also had the same functionality too

@Flowko
Copy link

Flowko commented Apr 24, 2024

@sadeghbarati any news about this ? since Listbox component was released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants