Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Collapsible open animation is triggered by splice on underlying data #920

Open
ricketyBridges opened this issue May 13, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ricketyBridges
Copy link

Environment

Development/Production OS: macOS Sonoma 14.4
Node version: 18.18.0
Radix Vue version: ^1.5.3
Vue version: ^3.4.15
CSS framework: Vanilla scss

Link to minimal reproduction

https://codesandbox.io/p/sandbox/collapsible-flicker-x59g7c

Steps to reproduce

Open a bunch of the collapsibles via the buttons. Then drag and drop to rearrange them.

Describe the bug

Using splice to rearrange an array of collapsibles causes the open animation to fire or flicker.

This occurs on drag start and when a drag ends (but only on the collapsible that is higher up). If all collapsibles start open, it does not occur, user must close/open first.

Expected behavior

If the dragged/spliced collapsible was previously open, it should stay open and not flicker.

Context & Screenshots (if applicable)

Seems similar to issue radix-ui/primitives#1074 (comment)
313472106-b7dedbcd-92f3-46dc-bba9-b0aa97f09ad7

@ricketyBridges ricketyBridges added the bug Something isn't working label May 13, 2024
@zernonia
Copy link
Collaborator

Does the solution mentioned here fix it? radix-ui/primitives#1074 (comment)

@ricketyBridges
Copy link
Author

Not sure if that solution is applicable here, as I cannot move the class into an inner element without losing animation completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants