-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Popover component misses aria-label #841
Comments
Yup seems like the issue from Radix UI. As a temporary workaround, you can always add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Link to minimal reproduction
https://www.radix-vue.com/components/popover.html
Steps to reproduce
Inspect code of the popover:
Describe the bug
It has
role="dialog"
but is missingaria-label
oraria-labelledby
.Expected behavior
I could workaround this by using an unique ID as label: https://stackblitz.com/edit/zxrcsg.
Context & Screenshots (if applicable)
Found the issue because the accessibility checks were not passing in Storybook. The rule is noted as "serious impact" in Axe: https://dequeuniversity.com/rules/axe/4.2/aria-dialog-name
Looks like Radix UI has the same issue: https://www.radix-ui.com/primitives/docs/components/popover
Also, the link in accessibility section is 404: https://www.radix-vue.com/components/popover.html#accessibility (goes to https://www.w3.org/WAI/ARIA/apg/patterns/dialogmodal)
The text was updated successfully, but these errors were encountered: