Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No multiple parents #1279

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

No multiple parents #1279

wants to merge 6 commits into from

Conversation

emmanuelmathot
Copy link
Collaborator

@emmanuelmathot emmanuelmathot commented May 7, 2024 •
edited

Related Issue(s): #1230

Proposed Changes:

  1. Clarify unique parent link requirement
  2. Added collection relation type for link in catalog and collection

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

@emmanuelmathot emmanuelmathot changed the title Nomultiparents No multiple parents May 7, 2024
@m-mohr
Copy link
Collaborator

m-mohr commented May 7, 2024 •
edited

I think we only really discussed parent links so far, i.e. #1230.

I don't think this necessarily should solve #1236 and #1273. At least I'd like to discuss it first.

m-mohr
m-mohr reviewed May 7, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed May 7, 2024
View reviewed changes
best-practices.md Outdated Show resolved Hide resolved
m-mohr
m-mohr requested changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@emmanuelmathot
Copy link
Collaborator Author

This PR is set at the agenda of the next STAC meetup along with the collections discussions.

@emmanuelmathot emmanuelmathot added this to the 1.1 milestone May 14, 2024
@m-mohr m-mohr linked an issue May 14, 2024 that may be closed by this pull request
Multiple parents? #1230
Open
@emmanuelmathot
Copy link
Collaborator Author

emmanuelmathot commented Jun 3, 2024 •
edited

Discussed in STAC meetup:

  • Single STAC parent and root in spec
  • Different encodings with same relation type
  • Leave collection out of PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-mohr m-mohr m-mohr requested changes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Multiple parents?
2 participants
@emmanuelmathot @m-mohr