Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang Script to Validate Podcasts #189

Open
rShetty opened this issue Feb 3, 2019 · 5 comments
Open

Golang Script to Validate Podcasts #189

rShetty opened this issue Feb 3, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rShetty
Copy link
Owner

rShetty commented Feb 3, 2019

Script should do the following

  • Validate the links of the podcasts (whether they are broken)
  • Validate the order of the podcasts in each category (and also categories)

Break the build when either of the above validations fail

@rShetty rShetty added enhancement New feature or request good first issue Good for newcomers labels Feb 3, 2019
@rShetty rShetty changed the title Go Script to Validate Podcasts Golang Script to Validate Podcasts Feb 3, 2019
@rShetty rShetty self-assigned this Feb 5, 2019
@pbnj
Copy link
Contributor

pbnj commented May 6, 2019

Hey @rShetty , I don't mind taking this issue on.

I already implemented something similar on my repo, so I have some experience.

I have some ideas about how I may go about solving these 2 problems that I want to run by you:

  • Validating links:

    1. parse the URL
    2. make a GET request
    3. anything other than a 200/302 consider it bad.
    4. follow re-directs and repeat.
  • Validating order of the podcasts:

    1. using blackfriday to parse markdown
    2. walk 1st-level bullets and sort alphabetically (ignoring The)

Let me know if you prefer another way you prefer.

Questions:

  • Are you planning on doing the same for non-ASCII languages (I think Russian Cyrillic is the only one at the moment)?
  • Do you feel that storing the data in a YAML/JSON format may be easier for (un)marshalling/processing the data and outputting into various formats (e.g. markdown)?

@rShetty
Copy link
Owner Author

rShetty commented May 10, 2019

@petermbenjamin Your ideas on implementation makes sense, Lets go ahead with it.
Are you planning on doing the same for non-ASCII languages (I think Russian Cyrillic is the only one at the moment)?
Was thinking to start with English and then expand to others.

Do you feel that storing the data in a YAML/JSON format may be easier for (un)marshalling/processing the data and outputting into various formats (e.g. markdown)?

We can do this as Version 2 of this implementation

Let me know if you have any questions. Thanks

@rShetty
Copy link
Owner Author

rShetty commented Sep 12, 2019

@petermbenjamin Let me know if you are still planning to work on this issue. Someone else can pick up.

@pbnj
Copy link
Contributor

pbnj commented Sep 16, 2019

@rShetty - Sorry for the delay. I have a bit of a busy schedule for the foreseeable future. Someone else can pick this up.

@Akshay-Kumar-Sharma7807

If it's not yet done maybe I can help.
I will make a github action to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants