Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_codecov_badge() URL seems incorrect now #1991

Open
DavisVaughan opened this issue May 15, 2024 · 2 comments
Open

use_codecov_badge() URL seems incorrect now #1991

DavisVaughan opened this issue May 15, 2024 · 2 comments

Comments

@DavisVaughan
Copy link
Member

i.e. here

url <- glue("https://app.codecov.io/gh/{repo_spec}?branch={default_branch}")

It generates a link like this:

https://app.codecov.io/gh/tidyverse/tidyr?branch=main

but if you go to that, it will still show master. It does not seem to know how to handle ?branch=main and just ignores it, and then shows what it thinks is the default branch, which is master unless you've changed it in the codecov settings.

It seems like this might be a more correct link?

https://app.codecov.io/gh/tidyverse/tidyr/tree/main

That shows main for me

@DavisVaughan
Copy link
Member Author

Ideally we'd just remove the branch piece entirely and show https://app.codecov.io/gh/tidyverse/tidyr, but since codecov doesn't automatically pick up git default branch changes, that is likely going to show master for all our repos until we go and change the setting on codecov.io too

@gaborcsardi
Copy link
Member

Just changed the default branches to main in tidyverse. Hopefully new repos will default to main since that's the default branch on GH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants