Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show mentions list when click on mention item #109

Open
komxvl opened this issue Oct 23, 2019 · 17 comments
Open

Show mentions list when click on mention item #109

komxvl opened this issue Oct 23, 2019 · 17 comments

Comments

@komxvl
Copy link

komxvl commented Oct 23, 2019

If I have a mention like @porsche, I want to click on this mention and then a list of mentions is shown if I click on the selected item the old item change to the new selected item.

@rajshivam
Copy link

I have the same requirement for my project as well. Have you implemented it yet?

@komxvl
Copy link
Author

komxvl commented Nov 20, 2019

Unfortunately no, if you have any ideas please share, thnx

@rajshivam
Copy link

One level of sub-mention should be doable but I'm thinking this sub-mention feature should be extensible. That sub-mention list might have further lists. What do you think?

@komxvl
Copy link
Author

komxvl commented Nov 21, 2019

Thank you for your interest in this. I create a jsfiddle, about what I mean

@rajshivam
Copy link

@komxvl your fiddle is about multi denotation chars, I've created a PR for the same #114

@komxvl
Copy link
Author

komxvl commented Nov 21, 2019

If you click on {{Jacob}} in an editor, the mention list is showing again.

@rajshivam
Copy link

Thank you for clarifying, I've created a PR for the same #115 .
Have tested with '#' denotationChar. Please check and let me know.

@komxvl
Copy link
Author

komxvl commented Nov 26, 2019

Thanks for your work, could your please explain me what I must to do for testing this feature?Thanks a lot.

@rajshivam
Copy link

I have already build the minified quill.mention.js in dist directory.
Just copy the contents of dist/quill.mention.min.js and paste to docs/quill.mention.min.js
In the docs directory, open index.html in a browser to test.

@komxvl
Copy link
Author

komxvl commented Nov 27, 2019

I tested this feature, and this is working nice. Thanks, for your job. If I find any mistakes, I will tell you about it!

@komxvl
Copy link
Author

komxvl commented Nov 28, 2019

@MadSpindel could you please update your library with @rajshivam changes, thnx guys!

@komxvl
Copy link
Author

komxvl commented Dec 10, 2019

Hi @rajshivam some conflicts in PR. Could please resolve it, thnx!

@rajshivam
Copy link

@komxvl Resolved.

@komxvl
Copy link
Author

komxvl commented Dec 17, 2019

Great work @rajshivam, thanks. @MadSpindel could you please merge this PR

@GitHubish
Copy link

GitHubish commented Jan 9, 2020

This feature would be really great! thanks @rajshivam !
I can't wait to test it.

@komxvl
Copy link
Author

komxvl commented Jan 9, 2020

@GitHubish I can't wait to test it too!!

@iamshouvikmitra
Copy link

Any updates on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants