Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickAccess window sometimes closes automatically in ~3 seconds after opening by the hotkey #211

Open
MurzNN opened this issue May 10, 2024 · 5 comments
Labels
bug Something isn't working needs triage

Comments

@MurzNN
Copy link

MurzNN commented May 10, 2024

Here is the video recording:

vokoscreenNG-2024-05-10_10-17-12.mp4

The QuickAccess window closes automatically if I don't start typing something in ~3 seconds.

@quexten
Copy link
Owner

quexten commented May 10, 2024

I think we should pass errors through properly here. It closes itself if it cannot get the vault data for some reason. But to figure out why it cannot get the vault contents, the logging shouldn't be dropped.

@quexten quexten added the bug Something isn't working label May 10, 2024
@quexten
Copy link
Owner

quexten commented May 11, 2024

Is this always or just sometimes? Also, what happens when you run flatpak run --command=goldwarden com.quexten.Goldwarden logins list DO NOT POST THE OUTPUT JUST MAKE SURE THERE IS JSON FORMATTED OUTPUT and how many entries do you approximately have (over 1k?) (visible in the video).

@MurzNN
Copy link
Author

MurzNN commented May 11, 2024

With current versions it happens every time, via clicking the Quick Access button, and the same - with the hotkey. But if I quickly catch the moment of window appearing, and start typing there something, the window is not closing.

@grackeon
Copy link

Got the same issue on 0.3.2.
The logins list command raises a JSON error, so maybe the window closing is related to this:

$ flatpak run --command=goldwarden com.quexten.Goldwarden logins list
panic: unexpected end of JSON input

goroutine 1 [running]:
github.com/quexten/goldwarden/cli/client.Reader({0xa035a0, 0xc00008a138})
	/home/runner/work/goldwarden/goldwarden/cli/client/unixsocketclient.go:40 +0xe5
github.com/quexten/goldwarden/cli/client.UnixSocketConnection.ReadMessage({{0xa095a0?, 0xc00008a138?}})
	/home/runner/work/goldwarden/goldwarden/cli/client/unixsocketclient.go:92 +0x3d
github.com/quexten/goldwarden/cli/client.UnixSocketConnection.SendCommand({{0xa095a0?, 0xc00008a138?}}, {0x8bbfa0?, 0xd86de0?})
	/home/runner/work/goldwarden/goldwarden/cli/client/unixsocketclient.go:88 +0x55
github.com/quexten/goldwarden/cli/client.UnixSocketClient.SendToAgent({0x0?}, {0x8bbfa0, 0xd86de0})
	/home/runner/work/goldwarden/goldwarden/cli/client/unixsocketclient.go:52 +0xae
github.com/quexten/goldwarden/cli/cmd.ListLogins({0x0?})
	/home/runner/work/goldwarden/goldwarden/cli/cmd/logins.go:102 +0x25
github.com/quexten/goldwarden/cli/cmd.init.func17(0xc0000f7200?, {0x934f22?, 0x4?, 0x934dfa?})
	/home/runner/work/goldwarden/goldwarden/cli/cmd/logins.go:78 +0x85
github.com/spf13/cobra.(*Command).execute(0xce8c20, {0xd86de0, 0x0, 0x0})
	/home/runner/go/pkg/mod/github.com/spf13/[email protected]/command.go:987 +0xab1
github.com/spf13/cobra.(*Command).ExecuteC(0xce8f00)
	/home/runner/go/pkg/mod/github.com/spf13/[email protected]/command.go:1115 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
	/home/runner/go/pkg/mod/github.com/spf13/[email protected]/command.go:1039
github.com/quexten/goldwarden/cli/cmd.Execute({{0x0, 0x0}, 0x0, {0xc000032280, 0x43}, 0x0, 0x0, {0x0, 0x0}, {0x0, ...}, ...})
	/home/runner/work/goldwarden/goldwarden/cli/cmd/root.go:29 +0xe6
main.main()
	/home/runner/work/goldwarden/goldwarden/main.go:54 +0x618

@luckycold
Copy link

Got the same issue on 0.3.2. The logins list command raises a JSON error, so maybe the window closing is related to this:

$ flatpak run --command=goldwarden com.quexten.Goldwarden logins list
panic: unexpected end of JSON input

goroutine 1 [running]:
github.com/quexten/goldwarden/cli/client.Reader({0xa035a0, 0xc00008a138})
	/home/runner/work/goldwarden/goldwarden/cli/client/unixsocketclient.go:40 +0xe5
github.com/quexten/goldwarden/cli/client.UnixSocketConnection.ReadMessage({{0xa095a0?, 0xc00008a138?}})
	/home/runner/work/goldwarden/goldwarden/cli/client/unixsocketclient.go:92 +0x3d
github.com/quexten/goldwarden/cli/client.UnixSocketConnection.SendCommand({{0xa095a0?, 0xc00008a138?}}, {0x8bbfa0?, 0xd86de0?})
	/home/runner/work/goldwarden/goldwarden/cli/client/unixsocketclient.go:88 +0x55
github.com/quexten/goldwarden/cli/client.UnixSocketClient.SendToAgent({0x0?}, {0x8bbfa0, 0xd86de0})
	/home/runner/work/goldwarden/goldwarden/cli/client/unixsocketclient.go:52 +0xae
github.com/quexten/goldwarden/cli/cmd.ListLogins({0x0?})
	/home/runner/work/goldwarden/goldwarden/cli/cmd/logins.go:102 +0x25
github.com/quexten/goldwarden/cli/cmd.init.func17(0xc0000f7200?, {0x934f22?, 0x4?, 0x934dfa?})
	/home/runner/work/goldwarden/goldwarden/cli/cmd/logins.go:78 +0x85
github.com/spf13/cobra.(*Command).execute(0xce8c20, {0xd86de0, 0x0, 0x0})
	/home/runner/go/pkg/mod/github.com/spf13/[email protected]/command.go:987 +0xab1
github.com/spf13/cobra.(*Command).ExecuteC(0xce8f00)
	/home/runner/go/pkg/mod/github.com/spf13/[email protected]/command.go:1115 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
	/home/runner/go/pkg/mod/github.com/spf13/[email protected]/command.go:1039
github.com/quexten/goldwarden/cli/cmd.Execute({{0x0, 0x0}, 0x0, {0xc000032280, 0x43}, 0x0, 0x0, {0x0, 0x0}, {0x0, ...}, ...})
	/home/runner/work/goldwarden/goldwarden/cli/cmd/root.go:29 +0xe6
main.main()
	/home/runner/work/goldwarden/goldwarden/main.go:54 +0x618

I get this same error. I have found though that if I run the hotkey on certain applications like my browser it doesn't automatically close on me. Although I think the window might be changing on me that allows for this between restarts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

4 participants