Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine grained notification settings #181

Open
linus-ha opened this issue Apr 29, 2024 · 4 comments
Open

Fine grained notification settings #181

linus-ha opened this issue Apr 29, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@linus-ha
Copy link

linus-ha commented Apr 29, 2024

I, as a user, want to be able to disable / enable certain notification types. It currently gets really annoying when there is a notification coming up every few minutes when VS Code does its automated “git fetch”.

Besides that: Disabling Notifications from the Gnome control center has no effect. If this is something goldwarden has to implement or if it's a bug on gnomes side is unknown to me. (#182)

Installed as a Flatpak. Version 0.2.13

@linus-ha
Copy link
Author

Okay, it seems like goldwarden is directly sending notifications via dbus messages instead of using the notification portal.
The gnome control center just disallows/disables the notification portal.
grafik

@quexten
Copy link
Owner

quexten commented Apr 29, 2024

Ah, so far using the org.freedesktop.Notifications dbus service has not become a problem, but this circumvents the portal settings, so we would need to migrate that to use the portal. You can probably take away the permission to talk to this service to disable all notifications (third row of the session bus entries in your screenshot). I don't think gnome provides fine grained notification settings, so that is something we would do in-app.

@quexten quexten added the enhancement New feature or request label Apr 29, 2024
@quexten quexten changed the title Notification settings Fine grained notification settings Apr 29, 2024
@quexten
Copy link
Owner

quexten commented Apr 29, 2024

At least for the notification permission, #182 now has a working PR (#184), waiting for a PR in the upstream portal dependency (rymdport/portal#11) to be merged.

@Jacalz
Copy link

Jacalz commented Apr 30, 2024

Thanks for the contribution. I have merged your PR and created a new release :)

@quexten quexten added the help wanted Extra attention is needed label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants