Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Element prevents correctly working under jsdom #72

Open
carsonreinke opened this issue Aug 31, 2020 · 0 comments
Open

Check for Element prevents correctly working under jsdom #72

carsonreinke opened this issue Aug 31, 2020 · 0 comments

Comments

@carsonreinke
Copy link

Under a jsdom environment Element is not an Object.

if (typeof Element === 'undefined' || !(Element instanceof Object)) {
    return;
}

https://github.com/que-etc/resize-observer-polyfill/blob/master/src/ResizeObserverSPI.js#L76

Probably simply just removing the later condition unless there was some reason for that.

Related to #50.

carsonreinke pushed a commit to carsonreinke/reinke.co that referenced this issue Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant