-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add valid labels for search button and input fields (a11y issue) #678
Comments
This is injected by our auto-complete library, so the simplest fix would be upstream- related issue: For now, postponing and I'll work on trying to get fixed upstream. |
Hi! |
Upstream issue is still opened, and iIssue here also as we didn't do any specific handling on Quarto side. As said, this would need to be dealt upstream in the autocomplete library. So work to be done (which is usally the status for issue still opened in this repo) |
Ah, yeah, makes sense. Thanks for getting back to me so quickly. |
Both the collapsed and expanded search features (the button, and then the input field) currently have
aria-labelledby
properties set that reference an element that doesn't exist (and, thus, they have no label)There are three associated accessibility issues I get related to the search:
Element:
<div class="aa-Autocomplete" role="combobox" aria-expanded="false" aria-haspopup="listbox" aria-labelledby="autocomplete-0-label">
Element:
<button class="aa-DetachedSearchButton">
Element:
<div class="aa-Autocomplete" role="combobox" aria-expanded="false" aria-haspopup="listbox" aria-labelledby="autocomplete-0-label">
Error: ARIA attribute element ID does not exist on the page: aria-labelledby="autocomplete-0-label"
The third presumably applies to the search input when opened on the element below:
As far as internationalization goes, it looks like the buttons have translation parameters in the Algolia docs.
Link to issue report from audit with axe: https://axe.deque.com/issues/7854d2a8-7632-43fd-98a7-ad22683ed4d5
The text was updated successfully, but these errors were encountered: